Share log file #133
Merged
Share log file #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdsantos
force-pushed
the
crash-reporting
branch
from
24d9997 to
7b53a64
Compare
aanorbel
approved these changes
Oct 3, 2024
Comment on lines
90
to
91
| private const val SENTRY_DSN = | ||
| "https://9dcd83d9519844188803aa817cdcd416@o155150.ingest.sentry.io/5619989" |
There was a problem hiding this comment.
Should this be a configuration ?
There was a problem hiding this comment.
I believe it's the same for all our variations of the app. Then Sentry splits the data by application ID.
aanorbel
reviewed
Oct 3, 2024
Comment on lines
57
to
62
| <<<<<<< HEAD | ||
| configureDescriptorAutoUpdate = appWorkerManager::configureDescriptorAutoUpdate, | ||
| fetchDescriptorUpdate = appWorkerManager::fetchDescriptorUpdate, | ||
| ======= | ||
| shareFile = ::shareFile, | ||
| >>>>>>> ec8eb37 (Share log file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.