Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tlsmiddlebox): if RemoteAddr is IPv6 set IPV6_UNICAST_HOPS #1517

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix(tlsmiddlebox): if RemoteAddr is IPv6 set IPV6_UNICAST_HOPS #1517

merged 2 commits into from
Mar 20, 2024

Conversation

Lanius-collaris
Copy link
Contributor

@Lanius-collaris Lanius-collaris commented Mar 7, 2024 •
edited
Loading

Checklist

Description

To set Hop Limit (IPv6) , we should set IPV6_UNICAST_HOPS option instead of IP_TTL.

@Lanius-collaris
Copy link
Contributor Author

ping @jbonisteel

bassosimone
bassosimone approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@bassosimone bassosimone merged commit 84eb16b into ooni:master Mar 20, 2024
24 checks passed
@Lanius-collaris Lanius-collaris deleted the fix-tlsmiddlebox branch March 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lanius-collaris @bassosimone