fix(minipipeline): handle IP-addr URLs in classic linear analysis #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
changed the title
bassosimone
changed the title
bassosimone
changed the title
bassosimone
changed the title
bassosimone
changed the title
bassosimone
changed the title
bassosimone
commented
Jan 24, 2024
| "alt-svc": true, | ||
| "content-length": true | ||
| }, | ||
| "Linear": [ |
There was a problem hiding this comment.
We clearly fixed the bug!
bassosimone
commented
Jan 24, 2024
| @@ -1,7 +1,75 @@ | |||
| { | |||
| "DNSLookupFailures": [], | |||
| "DNSLookupSuccesses": [], | |||
| "KnownTCPEndpoints": {}, | |||
| "KnownTCPEndpoints": { | |||
There was a problem hiding this comment.
We clearly fixed the bug!
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
…ni#1472) This diff fixes ooni/probe#1511 (comment). This is the rationale of the diff: we need to track the origin of IP addresses: * "dns" if discovered using DNS; * "th" if discovered using the test helper; * null otherwise. When filtering for classic analysis, we include "dns" entries if resolved using getaddrinfo, drop "th" entries because they're not relevant, and include null entries under the assumption that the probe discovered them either directly from the input URL or because a redirect redirected to an URL containing an IP address. We also update the minipipeline test suite and show that the only changes are related to the test added by ooni#1471.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff fixes ooni/probe#1511 (comment).
This is the rationale of the diff: we need to track the origin of IP addresses:
When filtering for classic analysis, we include "dns" entries if resolved using getaddrinfo, drop "th" entries because they're not relevant, and include null entries under the assumption that the probe discovered them either directly from the input URL or because a redirect redirected to an URL containing an IP address.
We also update the minipipeline test suite and show that the only changes are related to the test added by #1471.