fix(webconnectivitylte): make IDNA WAI #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff modifies webconnectivitylte to have full IDNA support. It turns out existing code for supporting IDNA was not WAI for yandex.ru when using https://яндекс.рф/. I have fixed IDNA code, I ensured we always use the same IDNA code, manually tested (see below), and then generated syntethic test cases for continuous integration. See this measurement: https://explorer.ooni.org/m/20240123110911.104106_IT_webconnectivity_f0a3b891c176125b While there, I started adding initial support for printing the measurement URL based on the measurement UID. Closes ooni/probe#1925. Part of ooni/probe#2652.
bassosimone
changed the title
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2652, ooni/probe#1925 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: not needed - [x] if you changed code inside an experiment, make sure you bump its version number: already bumped for 3.21.x ## Description This diff fixes webconnectivitylte to make IDNA support working as intended. It turns out existing code for supporting IDNA was not WAI for yandex.ru when using https://яндекс.рф/. I have fixed IDNA code, ensured we always use the same correct IDNA code, manually tested (see below), and then generated syntethic test cases for continuous integration. See this measurement: https://explorer.ooni.org/m/20240123110911.104106_IT_webconnectivity_f0a3b891c176125b. While there, I started adding initial support for printing the measurement URL based on the measurement UID. Closes ooni/probe#1925. Part of ooni/probe#2652.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This diff fixes webconnectivitylte to make IDNA support working as intended.
It turns out existing code for supporting IDNA was not WAI for yandex.ru when using https://яндекс.рф/. I have fixed IDNA code, ensured we always use the same correct IDNA code, manually tested (see below), and then generated syntethic test cases for continuous integration.
See this measurement: https://explorer.ooni.org/m/20240123110911.104106_IT_webconnectivity_f0a3b891c176125b.
While there, I started adding initial support for printing the measurement URL based on the measurement UID.
Closes ooni/probe#1925.
Part of ooni/probe#2652.