feat(webconnectivitylte): classic computes XBlockingFlags #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
added a commit
that referenced
this pull request
Jan 16, 2024
This PR contains yak shaving before doing ooni/probe#2640. We extracted this PR from #1446.
Conflicts: internal/minipipeline/analysis.go
bassosimone
commented
Jan 19, 2024
| XNullNullFlags: 8, // analysisFlagNullNullSuccessfulHTTPS | ||
| XStatus: 1, // StatusSuccessSecure | ||
| XBlockingFlags: 32, // AnalysisBlockingFlagSuccess | ||
| XNullNullFlags: 8, // analysisFlagNullNullSuccessfulHTTPS |
There was a problem hiding this comment.
This looks good. We're basically moving the success from XNullNullFlags (which is still ignored per the code changes in this pull request) to XBlockingFlags, which seems correct.
bassosimone
commented
Jan 19, 2024
| @@ -79,7 +79,7 @@ func dnsBlockingBOGON() *TestCase { | |||
| DNSExperimentFailure: nil, | |||
| DNSConsistency: "inconsistent", | |||
| XStatus: 4256, // StatusExperimentConnect | StatusAnomalyConnect | StatusAnomalyDNS | |||
| XDNSFlags: 1, // AnalysisFlagDNSBogon | |||
| XDNSFlags: 5, // AnalysisFlagDNSBogon | AnalysisDNSFlagUnexpectedAddrs | |||
There was a problem hiding this comment.
This change happens because bogons are also unexpected addresses. I think this is fine because we may have cases (some of which @hellais observed for Telstra, IIRC) where a bogon is serving us the correct result but we still want to note somewhere that we have seen a bogon even though such a bogon seems WAI.
bassosimone
commented
Jan 19, 2024
| XBlockingFlags: 32, // AnalysisBlockingFlagSuccess | ||
| XStatus: 2, // StatusSuccessCleartext | ||
| XDNSFlags: 4, // AnalysisDNSFlagUnexpectedAddrs | ||
| XBlockingFlags: 33, // AnalysisBlockingFlagDNSBlocking | AnalysisBlockingFlagSuccess |
There was a problem hiding this comment.
Even when we're successful, we want to note that we're not sure about the addresses.
bassosimone
commented
Jan 19, 2024
| XBlockingFlags: 32, // AnalysisBlockingFlagSuccess | ||
| XStatus: 1, // StatusSuccessSecure | ||
| XDNSFlags: 4, // AnalysisDNSFlagUnexpectedAddrs | ||
| XBlockingFlags: 33, // AnalysisBlockingFlagDNSBlocking | AnalysisBlockingFlagSuccess |
bassosimone
commented
Jan 19, 2024
| @@ -92,7 +92,7 @@ func httpDiffWithInconsistentDNS() *TestCase { | |||
| TitleMatch: false, | |||
| XStatus: 96, // StatusAnomalyHTTPDiff | StatusAnomalyDNS | |||
| XDNSFlags: 4, // AnalysisDNSFlagUnexpectedAddrs | |||
| XBlockingFlags: 35, // AnalysisBlockingFlagSuccess | AnalysisBlockingFlagDNSBlocking | AnalysisBlockingFlagTCPIPBlocking | |||
| XBlockingFlags: 17, // AnalysisBlockingFlagDNSBlocking | AnalysisBlockingFlagHTTPDiff | |||
There was a problem hiding this comment.
The previous success flag was a bug of the "orig" analysis engine.
bassosimone
commented
Jan 19, 2024
| @@ -37,7 +37,7 @@ func redirectWithConsistentDNSAndThenConnectionRefusedForHTTP() *TestCase { | |||
| HTTPExperimentFailure: "connection_refused", | |||
| XStatus: 8320, // StatusExperimentHTTP | StatusAnomalyConnect | |||
| XDNSFlags: 0, | |||
| XBlockingFlags: 32, // AnalysisBlockingFlagSuccess | |||
| XBlockingFlags: 2, // AnalysisBlockingFlagTCPIPBlocking | |||
There was a problem hiding this comment.
The previous success flag was a bug of the "orig" analysis engine.
bassosimone
commented
Jan 19, 2024
| @@ -75,7 +75,7 @@ func redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS() *TestCase { | |||
| HTTPExperimentFailure: "connection_refused", | |||
| XStatus: 8320, // StatusExperimentHTTP | StatusAnomalyConnect | |||
| XDNSFlags: 0, | |||
| XBlockingFlags: 32, // AnalysisBlockingFlagSuccess | |||
| XBlockingFlags: 2, // AnalysisBlockingFlagTCPIPBlocking | |||
There was a problem hiding this comment.
The previous success flag was a bug of the "orig" analysis engine.
bassosimone
commented
Jan 19, 2024
| @@ -113,7 +113,7 @@ func redirectWithConsistentDNSAndThenConnectionResetForHTTP() *TestCase { | |||
| HTTPExperimentFailure: "connection_reset", | |||
| XStatus: 8448, // StatusExperimentHTTP | StatusAnomalyReadWrite | |||
| XDNSFlags: 0, | |||
| XBlockingFlags: 8, // AnalysisBlockingFlagHTTPBlocking | |||
| XBlockingFlags: 12, // AnalysisBlockingFlagTLSBlocking | AnalysisBlockingFlagHTTPBlocking | |||
There was a problem hiding this comment.
The previous HTTP blocking flag was a bug of the "orig" analysis engine.
bassosimone
commented
Jan 19, 2024
| @@ -151,7 +151,7 @@ func redirectWithConsistentDNSAndThenConnectionResetForHTTPS() *TestCase { | |||
| HTTPExperimentFailure: "connection_reset", | |||
| XStatus: 8448, // StatusExperimentHTTP | StatusAnomalyReadWrite | |||
| XDNSFlags: 0, | |||
| XBlockingFlags: 8, // AnalysisBlockingFlagHTTPBlocking | |||
| XBlockingFlags: 4, // AnalysisBlockingFlagTLSBlocking | |||
There was a problem hiding this comment.
The previous HTTP blocking flag was a bug of the "orig" analysis engine.
bassosimone
commented
Jan 19, 2024
| @@ -182,7 +182,7 @@ func redirectWithConsistentDNSAndThenNXDOMAIN() *TestCase { | |||
| HTTPExperimentFailure: "dns_nxdomain_error", | |||
| XStatus: 8224, // StatusExperimentHTTP | StatusAnomalyDNS | |||
| XDNSFlags: 0, | |||
| XBlockingFlags: 8, // AnalysisBlockingFlagHTTPBlocking | |||
| XBlockingFlags: 1, // AnalysisBlockingFlagDNSBlocking | |||
There was a problem hiding this comment.
The previous HTTP blocking flag was a bug of the "orig" analysis engine.
bassosimone
commented
Jan 19, 2024
| @@ -220,7 +220,7 @@ func redirectWithConsistentDNSAndThenEOFForHTTP() *TestCase { | |||
| HTTPExperimentFailure: "eof_error", | |||
| XStatus: 8448, // StatusExperimentHTTP | StatusAnomalyReadWrite | |||
| XDNSFlags: 0, | |||
| XBlockingFlags: 8, // AnalysisBlockingFlagHTTPBlocking | |||
| XBlockingFlags: 12, // AnalysisBlockingFlagTLSBlocking | AnalysisBlockingFlagHTTPBlocking | |||
There was a problem hiding this comment.
Here we correctly recognize more causes of blocking
bassosimone
commented
Jan 19, 2024
| @@ -258,7 +258,7 @@ func redirectWithConsistentDNSAndThenEOFForHTTPS() *TestCase { | |||
| HTTPExperimentFailure: "eof_error", | |||
| XStatus: 8448, // StatusExperimentHTTP | StatusAnomalyReadWrite | |||
| XDNSFlags: 0, | |||
| XBlockingFlags: 32, // AnalysisBlockingFlagSuccess | |||
| XBlockingFlags: 4, // AnalysisBlockingFlagTLSBlocking | |||
There was a problem hiding this comment.
The previous success flag was a bug of the "orig" analysis engine.
bassosimone
commented
Jan 19, 2024
| @@ -297,7 +297,7 @@ func redirectWithConsistentDNSAndThenTimeoutForHTTP() *TestCase { | |||
| HTTPExperimentFailure: "generic_timeout_error", | |||
| XStatus: 8704, // StatusExperimentHTTP | StatusAnomalyUnknown | |||
| XDNSFlags: 0, | |||
| XBlockingFlags: 8, // AnalysisBlockingFlagHTTPBlocking | |||
| XBlockingFlags: 12, // AnalysisBlockingFlagTLSBlocking | AnalysisBlockingFlagHTTPBlocking | |||
There was a problem hiding this comment.
Here we correctly recognize more causes of blocking.
bassosimone
commented
Jan 19, 2024
| @@ -336,7 +336,7 @@ func redirectWithConsistentDNSAndThenTimeoutForHTTPS() *TestCase { | |||
| HTTPExperimentFailure: "generic_timeout_error", | |||
| XStatus: 8704, // StatusExperimentHTTP | StatusAnomalyUnknown | |||
| XDNSFlags: 0, | |||
| XBlockingFlags: 32, // AnalysisBlockingFlagSuccess | |||
| XBlockingFlags: 4, // AnalysisBlockingFlagTLSBlocking | |||
There was a problem hiding this comment.
The previous success flag was a bug of the "orig" analysis engine.
bassosimone
changed the title
bassosimone
changed the title
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This PR contains yak shaving before doing ooni/probe#2640. We extracted this PR from ooni#1446.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff modifies the "classic" analysis engine to compute XBlockingFlags. While there, make sure that the flags we compute make sense thus fixing analysis bugs in the previously used "orig" engine. Part of ooni/probe#2640.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff modifies the "classic" analysis engine to compute XBlockingFlags. While there, make sure that the flags we compute make sense thus fixing analysis bugs in the previously used "orig" engine.
Part of ooni/probe#2640.