Connector validation #4016
Merged
Connector validation #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| error_msg = str(e) | ||
| queue.put(error_msg) # Send the exception to the parent process | ||
|
|
||
| sys.exit(256) # use 256 to indicate a connector validation error |
There was a problem hiding this comment.
this ties the job client to connectors ... is there a way to separate this? Also the 256 is an issue as mentioned earlier.
There was a problem hiding this comment.
Updated to be more in line with what we'd expect here!
| @@ -283,6 +287,7 @@ function Main({ ccPairId }: { ccPairId: number }) { | |||
| status={ccPair.last_index_attempt_status || "not_started"} | |||
| disabled={ccPair.status === ConnectorCredentialPairStatus.PAUSED} | |||
| isDeleting={isDeleting} | |||
| isInvalid={ccPair.status === ConnectorCredentialPairStatus.INVALID} | |||
There was a problem hiding this comment.
Should isDeleting and isInvalid be part of a single enum?
There was a problem hiding this comment.
Think this is fair generally- lots of re-use across the board
| : isDisabled | ||
| ? "Connector must be re-enabled before indexing" | ||
| : undefined | ||
| isInvalid |
There was a problem hiding this comment.
Do we like this pattern? I find it hard to read.
pablonyx
force-pushed
the
connector_validation
branch
2 times, most recently
from
17a68ed to
090c7c0
Compare
pablonyx
force-pushed
the
connector_validation
branch
from
090c7c0 to
3cfeb16
Compare
rkuo-danswer
approved these changes
Feb 17, 2025
pablonyx
force-pushed
the
connector_validation
branch
from
0743681 to
d46bc78
Compare
pablonyx
force-pushed
the
connector_validation
branch
from
907a0d3 to
8ea54e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds connector validation for ccpair creation / credential swapping.
New enum for ccpair status:
invalid- marks ccpairs which have an invalid configuaitonScreen.Recording.2025-02-16.at.5.58.02.PM.mov
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.