Allow all LLMs for image generation assistants #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
force-pushed
the
allow_all_assistants
branch
from
ed71f2b to
12217f5
Compare
Weves
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Hmm, I'm running into as I tested again:
Maybe we could do some additional prompt tuning to prevent this? Or we could just hardcode a response based on the prompts sent over to dalle.
Also, would prefer to not have the warnings for a case where there are no images in the chat even if image generation is enabled. I don't think that represents much of a degradation in experience
Weves
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1297/never-hide-non-image-assistants
Screen.Recording.2025-01-20.at.6.03.37.PM.mov
How Has This Been Tested?
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.