Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small background telemetry fix #3706

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Small background telemetry fix #3706

merged 1 commit into from
Jan 19, 2025

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Jan 18, 2025

Description

  1. We were sometimes sending over multiple values, causing the metric to be ignored by the telemetry server.
  2. We could miss some connector status metrics if another index attempt has been created before the metric was emitted.

How Has This Been Tested?

Ran locally, verified that the telemetry server could pick up the metrics.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 11:52pm

@Weves Weves force-pushed the small-telemetry-fix branch from 7e28c17 to 2900e58 Compare January 18, 2025 23:43
@Weves Weves merged commit a72bd31 into main Jan 19, 2025
13 checks passed
@Weves Weves deleted the small-telemetry-fix branch January 19, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant