Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix follow ups in thread + fix user name #3686

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Fix follow ups in thread + fix user name #3686

merged 3 commits into from
Jan 16, 2025

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Jan 15, 2025

Description

  1. Fixes follow ups in threads. A table was missing, which caused follows ups to fail (SQLAlchemy tries accessing a table that doesn't exist).
  2. Improves the prompt. Previously was a bit nasty (e.g. the final query would look like nQUERY:\nChris Weaver said in Slack:\nhi' which caused weird answers). Moves back to the single message history that happens before the task prompt + removes the X said in Slack part before the final query to simplify the tasks for the LLM.

How Has This Been Tested?

Tested follow-ups, directly in channel, search assistant in web UI, and general assistant in web UI.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 2:15am

@Weves Weves enabled auto-merge January 16, 2025 02:12
@Weves Weves added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 8a4d762 Jan 16, 2025
13 checks passed
@Weves Weves deleted the slack-followup-fix branch January 16, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants