Fully remove visit API #3621
Merged
Fully remove visit API #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rkuo-danswer
reviewed
Jan 7, 2025
pablonyx
force-pushed
the
fully_remove_visit
branch
from
e2066d2 to
52fac26
Compare
rkuo-danswer
approved these changes
Jan 8, 2025
pablonyx
force-pushed
the
fully_remove_visit
branch
from
be09b90 to
85fa327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Centralize logic so we can migrate off visit API and use our versioning schema more liberally
How Has This Been Tested?
Metadata syncing, indexing, deletion (multi tenant + not)
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.