Add support for OAuth connectors that require user input #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rkuo-danswer
approved these changes
Jan 1, 2025
| ), | ||
| })} | ||
| onSubmit={(values, formikHelpers) => { | ||
| console.log("HI"); |
There was a problem hiding this comment.
nit: extraneous log line
| @@ -124,6 +125,15 @@ def _process_egnyte_file( | |||
|
|
|||
|
|
|||
| class EgnyteConnector(LoadConnector, PollConnector, OAuthConnector): | |||
| class AdditionalOauthKwargs(OAuthConnector.AdditionalOauthKwargs): | |||
| egnyte_base_domain: str = Field( | |||
| title="Egnyte Base Domain", | |||
There was a problem hiding this comment.
i think this would technically be a subdomain? Although not if Egnyte has some standard terminology around this.
There was a problem hiding this comment.
kind of - they have things like https://{Egnyte Domain}.egnyte.com/pubapi/ in their docs. So not quite Base Domain, but not subdomain either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports a new paradigm where the user first fills in a form, then goes through the OAuth flow.
Without this, on our Cloud, everyone would be directed to OUR egnyte domain (which they obviously don't have an account on) -> they couldn't set it up.
Screen.Recording.2024-12-31.at.4.24.40.PM.mov
How Has This Been Tested?
Ran Egnyte connector locally.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.