-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Permission Syncing for Salesforce #3551
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
return censored_chunk | ||
|
||
|
||
# TODO: Generalize this to other sources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would suggest just following along with the tests to understand this lol
|
||
DOC_SOURCE_TO_CHUNK_CENSORING_FUNCTION: dict[ | ||
DocumentSource, | ||
# list of chunks to be censored and the user email. returns censored chunks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the general inputs might change if we add more sources as needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed in person, just needs some small comments around usage/syncing of null id strings.
Description
This permission enforcement is done by section post query instead of how the other ones are done
How Has This Been Tested?
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.