Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle subclass of cycles in related object selections #979

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Conversation

beckyjackson
Copy link
Contributor

@beckyjackson beckyjackson commented Mar 15, 2022

Resolves #976

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

Break out of recursion in selecting ancestors/descendants if an object is already in the set. This makes sure that if a class is asserted to be both equivalent to and a subclass of another class (see BFO role/CHEBI role in PATO example), we won't get stuck in an infinite loop.

@jamesaoverton jamesaoverton merged commit 930f156 into master Mar 21, 2022
@jamesaoverton jamesaoverton deleted the 976-fix branch March 21, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackOverflowError with "robot remove"
2 participants