Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to rename command #960

Merged
merged 10 commits into from
Jun 9, 2022
Merged

Updates to rename command #960

merged 10 commits into from
Jun 9, 2022

Conversation

beckyjackson
Copy link
Contributor

@beckyjackson beckyjackson commented Jan 13, 2022

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

Single mappings
Right now, rename only accepts a file of mappings. If you're only renaming one or two IRIs, this can be a little inconvenient. I added a --rename option which accepts two arguments, the original IRI and the new IRI.

Updating labels
I've also added support for a third column in the --mappings file. The user can provide a new label for the updated term in this third column. If there are only two columns or the column is left empty, the label stays the same (current behaviour to support backwards compatibility)

@beckyjackson beckyjackson changed the title Add --rename option to rename Updates to rename command Jan 14, 2022
docs/rename.md Outdated Show resolved Hide resolved
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy about this feature. Thanks!

@beckyjackson
Copy link
Contributor Author

Thanks for your review @matentzn ! I updated the RDFS label docs and added some code to validate the header line first.

@jamesaoverton jamesaoverton added this to the 1.8.4 milestone Jun 6, 2022
@jamesaoverton jamesaoverton merged commit 39a3d17 into master Jun 9, 2022
@jamesaoverton jamesaoverton deleted the rename-single branch June 9, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants