Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude log4j from elk import, drop redundant logback.xml #953

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Exclude log4j from elk import, drop redundant logback.xml #953

merged 2 commits into from
Dec 16, 2021

Conversation

jamesaoverton
Copy link
Member

@jamesaoverton jamesaoverton commented Dec 16, 2021 •
edited
Loading

#948 did not actually exclude log4j from elk when I checked with mvn dependency:tree.

The maven-shade plugin also warned about duplicate logback.xml files in robot-command and robot-core.

beckyjackson
beckyjackson approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@beckyjackson beckyjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me. Sorry, I should have checked the dependency tree!

@jamesaoverton jamesaoverton merged commit f794145 into master Dec 16, 2021
@jamesaoverton jamesaoverton deleted the elk-log4j branch December 16, 2021 16:38
@jamesaoverton jamesaoverton mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckyjackson beckyjackson beckyjackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesaoverton @beckyjackson