884 fix patch

[matentzn]

Two suggestions @beckyjackson :

1. We should ignore some-obsolete subclassOf Thing. this error is so frequent, it will totally pollute the test.
2. In an attempt to reduce spurious diffs over ROBOT report (see Report: Bind anonymous nodes to a generic label to avoid cluttering diff #873) I would suggest to avoid blank nodes in robot report.

[matentzn]

Something is wrong wait a moment..

[matentzn]

Ok now

[beckyjackson]

• I think "Use in anonymous expression" should be rephrased as just "anonymous expression", since that's the entity we're referring to.

[beckyjackson]

Thanks! I just see two things:

• Remove FILTER ( ?value != oboInOwl:ObsoleteClass ) at line 32; a deprecated class should never be equivalent or disjoint with oboInOwl:ObsoleteClass, only a subclass of it
• The anonymous expression check is duplicated. The first one should be removed, and just use the one where you're binding the string as ?entity.

[matentzn]

The anonymous expression check is duplicated. The first one should be removed, and just use the one where you're binding the string as ?entity.

I wanted to increase the readability of cases where the axiom in question is a simple existential restriction; if you check the FILTER() expressions in both cases, you will find that one of these "duplicates" looks for cases were the entity is named, and then can be printed as part of the robot command.. Does this make sense?

[beckyjackson]

Edit: I totally missed that one uses isBlank and the other uses !isBlank, these are different.

OK - I don't think there should be duplicates within the report because that will conflate the number of issues. Both of these return anonymous expressions, and the first one just returns a (very unhelpful) blank node ID, which won't help the user locate the usage anyway, so I think it should be removed:

{
 VALUES ?property {
   owl:someValuesFrom
   owl:allValuesFrom
 }
 ?value a owl:Class ;
        owl:deprecated true .
 ?entity ?x ?rest .
 ?rest a owl:Restriction ;
       ?property ?value .
 FILTER(!isBlank(?entity))
}
UNION
{
 VALUES ?property {
   owl:someValuesFrom   
   owl:allValuesFrom
 }
 ?value a owl:Class ;
        owl:deprecated true .
 ?e ?x ?rest .
 ?rest a owl:Restriction ;
       ?property ?value .
 FILTER(isBlank(?e))
 BIND("anonymous expression" as ?entity)
}