Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML lists to export #703

Merged
merged 9 commits into from
Jan 21, 2021
Merged

Add HTML lists to export #703

merged 9 commits into from
Jan 21, 2021

Conversation

beckyjackson
Copy link
Contributor

@beckyjackson beckyjackson commented Jun 6, 2020

Resolves #633

This should probably wait on #691 and #699 before merging

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

Adds html-list format to export to output reports in a simple HTML list:

image

I tried using the Bootstrap inline lists, but it looked kind of weird. This will also support the --standalone option that we are adding in #691 - --standalone false will not include the <head> and <body> tags.

Also fixes a minor bug with the HTML renderer in which & and < symbols in text would cause issues with the HTML. These are now replaced by &amp; and &lt;.

@beckyjackson beckyjackson marked this pull request as draft June 6, 2020 14:33
@beckyjackson beckyjackson changed the title Add HTML lists [do not merge] Add HTML lists to export Jun 6, 2020
@beckyjackson beckyjackson marked this pull request as ready for review September 25, 2020 17:56
Copy link
Member

@jamesaoverton jamesaoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay.

Overall this looks good but I'd like some changes.

Copy link
Member

@jamesaoverton jamesaoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jamesaoverton jamesaoverton added this to the v1.8.0 milestone Jan 20, 2021
@beckyjackson beckyjackson merged commit 9b86754 into master Jan 21, 2021
@beckyjackson beckyjackson deleted the html-list branch January 21, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export HTML lists
2 participants