Fix repair merge axiom annotations #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so the diff will be easier to read for the extended repair check I intend to add in the next commit.
For some reason, ROBOT repair --merge-axiom-annotations not only was restricted to annotation axioms (which is wrong), it also drops logical axioms with annotations as they are (1) first added to the heap of axioms that need to be processed, (2) dropped from the ontology because they are in that heap and finally (3) because of the wrong conditional we are fixing here, not added back. Adding and example for axiom annotation merging on subclass axioms to our test case
|
@jamesaoverton to review this more easily, @gouttegd taught me a great trick: review the commits one by one. This way, you don't see the big normalisation diffs in the test cases, and you only have to review 2 lines of code and about 10 lines of test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, ROBOT repair --merge-axiom-annotations not only was restricted to annotation axioms (which is wrong), it also drops logical axioms with annotations as they are (1) first added to the heap of axioms that need to be processed, (2) dropped from the ontology because they are in that heap and finally (3) because of the wrong conditional we are fixing here, not added back.
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updated