Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to OWL API 4.5.25 (not released yet) #1093

Merged
merged 8 commits into from
Feb 16, 2023
Merged

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Feb 13, 2023

Resolves [#1088, resolves #1089]

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

Do not merge, depends on:

And new release (4.5.25 does not exist yet).

@matentzn matentzn requested a review from hkir-dev February 13, 2023 20:33
@hkir-dev
Copy link
Contributor

Can we update the version of owlapi-api and owlapi-apibinding dependencies in both poms as well?

@matentzn
Copy link
Contributor Author

@hkir-dev done, check again? thx Today we will get the OWL API release as well! Later tonight but still!

Copy link
Contributor

@hkir-dev hkir-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once the OWL Api is ready we can update the CHANGELOG.md and merge.

@matentzn matentzn marked this pull request as ready for review February 16, 2023 07:00
This IRI is no longer parseable in OWL API 3.5.25
@matentzn
Copy link
Contributor Author

@jamesaoverton this is ready, but one integration test that should have failed during the last release only now started failing, see #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OWLAPI 4.5.24 adds a weird axiom annotation to OBO serialisation
3 participants