Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask for disjoint annotation properties #1087

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Don't ask for disjoint annotation properties #1087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Changed
- Upgrade OWLAPI to 4.5.24 [#1086]

### Fixed
- Downgrade SnakeYaml to 1.31 [#1071]
- Don't check for disjoint annotation properties [#1084]

## [1.9.1] - 2022-10-28

Expand Down Expand Up @@ -334,6 +339,7 @@ First official release of ROBOT!
[`validate`]: http://robot.obolibrary.org/validate

[#1086]: https://github.com/ontodev/robot/pull/1086
[#1084]: https://github.com/ontodev/robot/issues/1084
[#1071]: https://github.com/ontodev/robot/pull/1071
[#1061]: https://github.com/ontodev/robot/issues/1061
[#1030]: https://github.com/ontodev/robot/issues/1030
Expand Down
14 changes: 1 addition & 13 deletions robot-core/src/main/java/org/obolibrary/robot/ExportOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,6 +1136,7 @@ private static Row getRow(OWLOntology ontology, Table table, OWLEntity entity) t
break;
case "http://www.w3.org/2002/07/owl#disjointWith":
// Disjoint Entities
// Does not apply to annotation properties.
if (entity.isOWLClass()) {
Collection<OWLClassExpression> disjoints =
EntitySearcher.getDisjointClasses(entity.asOWLClass(), ontology);
Expand All @@ -1149,19 +1150,6 @@ private static Row getRow(OWLOntology ontology, Table table, OWLEntity entity) t
includeNamed,
includeAnonymous));

} else if (entity.isOWLAnnotationProperty()) {
Collection<OWLAnnotationProperty> disjoints =
EntitySearcher.getDisjointProperties(entity.asOWLAnnotationProperty(), ontology);
row.add(
getObjectCell(
disjoints,
col,
displayRendererType,
sortRendererType,
provider,
includeNamed,
includeAnonymous));

} else if (entity.isOWLDataProperty()) {
Collection<OWLDataPropertyExpression> disjoints =
EntitySearcher.getDisjointProperties(entity.asOWLDataProperty(), ontology);
Expand Down