[#1016] Fixes JSON report serialisation #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And @jamesaoverton I hope to "sell" the changes to Path API here :-) - they are needed to load the profile.txt inside the tests. |
|
Much appreciated. I'm off this week, but I will do my best to catch up when I get back next week. |
psiotwo
changed the title
|
Again this code looks good, but I'm worried about backwards compatibility. @matentzn Do you use YAML output from ROBOT report in any of your projects? |
@jamesaoverton no, I only ever export to TSV or HTML! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [#1016]
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedActually the added tests are maybe more valuable then the resolution itself - since I do not know what was the rationale behind the way the double-quotes in YAML serialisation were escaped before I honestly do not know what I have broken by this change - just hope that not too much :-) ...