Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robot doesn't get pH from current UO by MIREOT #709

Closed
turbomam opened this issue Jun 30, 2020 · 5 comments · Fixed by #710
Closed

robot doesn't get pH from current UO by MIREOT #709

turbomam opened this issue Jun 30, 2020 · 5 comments · Fixed by #710
Assignees

Comments

@turbomam
Copy link

turbomam commented Jun 30, 2020

the pH unit is http://purl.obolibrary.org/obo/UO_0000196

It appears twice in the hierarchy, with two different parent classes, and it has also been punned to an individual.

 markampa$ grep http://purl.obolibrary.org/obo/UO_0000196 ontology_downloads/uo.owl 
    <!-- http://purl.obolibrary.org/obo/UO_0000196 -->
    <owl:NamedIndividual rdf:about="http://purl.obolibrary.org/obo/UO_0000196">
                    <rdf:Description rdf:about="http://purl.obolibrary.org/obo/UO_0000196"/>
    <!-- http://purl.obolibrary.org/obo/UO_0000196 -->
    <owl:NamedIndividual rdf:about="http://purl.obolibrary.org/obo/UO_0000196"/>
    <rdf:Description rdf:about="http://purl.obolibrary.org/obo/UO_0000196">

But ROBOT doesn't seem to find it with MIREOT:

markampa$ robot extract --verbose --method MIREOT --input ./ontology_downloads/uo.owl \
  --lower-term http://purl.obolibrary.org/obo/UO_0000196 --output pH.ttl

markampa$ cat pH.ttl 
@prefix : <http://purl.obolibrary.org/obo/uo.owl#> .
@prefix owl: <http://www.w3.org/2002/07/owl#> .
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix xml: <http://www.w3.org/XML/1998/namespace> .
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@base <http://purl.obolibrary.org/obo/uo.owl> .

<http://purl.obolibrary.org/obo/uo.owl> rdf:type owl:Ontology .

###  Generated by the OWL API (version 4.5.6) https://github.com/owlcs/owlapi
@turbomam
Copy link
Author

And it doesn't return a Ontology does not contain error (which is good, I guess.)

SLME STAR does find it.

@beckyjackson
Copy link
Contributor

Looking at UO, "pH" is both a class and an individual, which I think confuses MIREOT since MIREOT only handles classes.

@jamesaoverton - how do we want to handle this case? Ignore the individual and just extract the class?

@beckyjackson
Copy link
Contributor

Side note @turbomam - if you want to extract the "pH" class, you can run this as a workaround for now:

robot remove --input uo.owl --select individuals \
      extract --method mireot --lower-term UO:0000196 --output ph.ttl

@cmungall
Copy link
Contributor

cmungall commented Jul 2, 2020

Thanks @beckyjackson the workaaround is good for mireot

for SLME please read the note on individuals here: http://robot.obolibrary.org/extract

Re punning See also bio-ontology-research-group/unit-ontology#23

to confuse things further I am requesting units as datatypes: bio-ontology-research-group/unit-ontology#29 to support OBOFoundry/COB#35

I think we're going to need to do some work on UO to make subsets for ordinary humans to comprehend @kaiiam may work on this

@kaiiam
Copy link

kaiiam commented Jul 2, 2020

@cmungall yes hopefully I'll be able to depends on my work situation for next year. I plan to begin improving UO starting with refactoring the repo to use ODK, and then we can figure what kinds of subsets and or patterns I should add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants