Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid reference violations for built-ins #455

Merged
merged 1 commit into from
May 7, 2019
Merged

Fix invalid reference violations for built-ins #455

merged 1 commit into from
May 7, 2019

Conversation

beckyjackson
Copy link
Contributor

For #374. Ignore owl:Thing, owl:Nothing, and the top and bottom properties when checking if an entity is dangling.

Previously, when running reason over BFO, this error was logged:

2019-03-18 14:24:12,787 ERROR org.obolibrary.robot.ReasonOperation - Reference violation: InvalidReferenceViolation [axiom=SubClassOf(<http://purl.obolibrary.org/obo/BFO_0000001> owl:Thing), referencedObject=owl:Thing, category=DANGLING]

After this change, no errors are logged when reasoning over BFO.

@jamesaoverton jamesaoverton merged commit aa9b186 into ontodev:master May 7, 2019
@beckyjackson beckyjackson deleted the invalid-reference-fix branch May 23, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beckyjackson @cmungall @jamesaoverton