Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance existing diff command, separate logic from display #432

Closed
cmungall opened this issue Feb 2, 2019 · 4 comments
Closed

Enhance existing diff command, separate logic from display #432

cmungall opened this issue Feb 2, 2019 · 4 comments
Assignees

Comments

@cmungall
Copy link
Contributor

cmungall commented Feb 2, 2019

Core requirements:

  • separate diff logic from diff rendering
  • define a JSON representation of a diff that can be used in a variety of renderers, stored in a database, etc
  • include a default markdown renderer in ROBOT, with options to show at different levels of granularity

Additional requirements that could be added later:

  • reasoner diff
  • ability to collapse low-level axiom-oriented diffs into user-centered model (e.g. move class, obsolete class)
  • reverse operation, aka patch - e.g. take a diff file and apply it
  • services (@balhoff has this: https://stars-app.renci.org/owldiff/)
    • would be good if this could be invoked a la ontobot via a message in the ticket
  • github agents for showing markdown of PRs and for making PRs for patches

These more advanced requirements are described in a separate doc INCA Change Language

The core idea is to separate logic from display. Implement logic once, make sure it is scalable.

All kinds of nice displays are possible once we do this, implementable in the most appropriate language; e.g. the old go-diffs that used coloration to nice effect to see textual diffs on a per string literal level.

#33 #360

@cmungall
Copy link
Contributor Author

Looping @lpalbou into conversation

@lpalbou
Copy link

lpalbou commented Aug 22, 2019

@balhoff

Go-stats original ticket: geneontology/go-site#842 (comment)

The ontology diff (json): https://geneontology-test2.s3.amazonaws.com/2019-07-01/go-ontology-changes.json
Tsv version: https://geneontology-test2.s3.amazonaws.com/2019-07-01/go-ontology-changes.tsv

These files should soon be on the current.geneontology.org too.

[EDIT]: updated the links for ontology diff json/tsv above

@cmungall
Copy link
Contributor Author

I believe this ticket can be closed? Some of the stretch reqts could go to a new ticket.

I would still like a summary report such as the one Laurent showed, but maybe this could be done trivially by operating on a json output?

@jamesaoverton
Copy link
Member

Ok. The primary issue has been addressed, so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants