Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report invalid_xrefs check forbids the dash character (-). Should it? #395

Closed
dougli1sqrd opened this issue Nov 6, 2018 · 6 comments
Closed
Assignees
Labels

Comments

@dougli1sqrd
Copy link
Contributor

Should the xref check forbid the dash character in the prefix of a xref ID? -.

For example:
UM-BBD_reactionID:r0982

There are ~800 violations in go-edit.obo. Thanks!

@dougli1sqrd dougli1sqrd self-assigned this Nov 6, 2018
@dougli1sqrd
Copy link
Contributor Author

Tagging @cmungall

@beckyjackson
Copy link
Contributor

I hadn't seen the dash used in CURIEs previously, but if it's a valid prefix then it can easily be removed from the query. Thanks for finding all of these!

@dougli1sqrd
Copy link
Contributor Author

Ha yeah, for sure. Yeah, I'm just trying to replace our existing queries with the report. It's possible the xrefs really don't want dashes, in which case all those are real errors!

@dougli1sqrd
Copy link
Contributor Author

Chris says dashes are allowed.

@beckyjackson
Copy link
Contributor

Awesome, thanks! I added a commit to #394 to fix this. I'm putting a DO NOT MERGE in the label until we work out the rest of the things in #391.

@beckyjackson
Copy link
Contributor

#394 has been merged in so I'm going to close this. Please feel free to re-open if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants