Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting option for export #22

Merged
merged 2 commits into from
May 2, 2024
Merged

Add sorting option for export #22

merged 2 commits into from
May 2, 2024

Conversation

ckindermann
Copy link
Contributor

This implements #20

@ckindermann
Copy link
Contributor Author

We already use -s as a flag for --streaming. I used -l as a flag for --sort (because it's a lexicographic sort). Also, the options --streaming and --sort cannot be combined. This is not an issue per se, but if we use --sort by default, then users will expect this sorted output. So, we should probably warn users about outputs not being sorted when using --streaming if --sort is configured as a default. Alternatively, we don't make --sort a default and throw an error when users set both --steaming and --sort (this is the current behavior).

@ckindermann ckindermann marked this pull request as ready for review May 1, 2024 04:29
@jamesaoverton
Copy link
Member

That fix worked for me. Thanks!

@jamesaoverton jamesaoverton merged commit 99ed71b into main May 2, 2024
@jamesaoverton jamesaoverton deleted the sort-export branch May 2, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants