Use TFLite Interpreter's public instead of private API to get tensor details #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q-ycong-p
force-pushed
the
tf212_hotfix
branch
7 times, most recently
from
df33fd2 to
32f644a
Compare
…unbreak UT TF-2.12.0 introduced API change that breaks tf2onnx UT tests on the tflite paths, due to the addition of compulsory subgraph arg to several function's input signature: tensorflow/tensorflow@55d84d7 This commit is a temporary hotfix to unbreak related UT failure. Existing tf2onnx's use cases get tflite Interpreter's tensors from model's first subgraph only. The hotfix hard-codes subgraph index to `0` to retain the same behavior while resolves API diff. Signed-off-by: Yu Cong <congyc@amazon.com>
q-ycong-p
changed the title
|
Some tests failed during environment setup independent to code diff. How can we rerun the tests without force push? |
Close and reopen this PR should work. |
fatcat-z
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TF-2.12.0 introduced API change that breaks tf2onnx UT tests on the tflite paths, due to the addition of compulsory subgraph arg to several function's input signature:
tensorflow/tensorflow@55d84d7
This commit changes tf2onnx functions that call to TFLite Interpreter class's private
_get_tensor_details, to instead call its public APIget_tensor_details. I think the code change is functionality-wise equivalent, from tf2onnx's usage perspective, and circumvent backward comp issue from using a private function.#2154