-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the default opset version for tf2onnx. #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Zhang <jiz@microsoft.com>
Signed-off-by: Jay Zhang <jiz@microsoft.com>
Resolve the issue #1911. |
hwangdeyu
reviewed
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the README.md#onnx at the same time?
Signed-off-by: Jay Zhang <jiz@microsoft.com>
Good catch. |
hwangdeyu
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
yan12125
pushed a commit
to archlinuxcn/repo
that referenced
this pull request
Jun 13, 2022
Fix tests failed after the default opset is upgraded from 9 to 13 [1]. Also switches from python-install to python-installer. [1] onnx/tensorflow-onnx#1946
yan12125
pushed a commit
to EMCLab-Sinica/DynBal
that referenced
this pull request
Jul 7, 2022
* CP decomposition * Tucker-2 decomposition * QAT * convert-har: use opset 9 explicitly Some codes are not compatible with newer opsets yet, while newer tf2onnx defaults to opset 13 [1]. Specify the opset to keep compaibility. Also investigates the issue from the newer API tf2onnx.convert.from_graph_def() and update comments. * Conv: fix recovery for group convolution * Faster group convolution * decomposition/fc: merge small filters * Double scales for asymmetric quantization * Add: strip states before scaling inputs [1] onnx/tensorflow-onnx#1946
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Jul 30, 2022
Fix tests failed after the default opset is upgraded from 9 to 13 [1]. Also switches from python-install to python-installer. [1] onnx/tensorflow-onnx#1946
yan12125
pushed a commit
to EMCLab-Sinica/DynBal
that referenced
this pull request
Aug 7, 2022
Some codes are not compatible with newer opsets yet, while newer tf2onnx defaults to opset 13 [1]. Specify the opset to keep compaibility. Also investigates the issue from the newer API tf2onnx.convert.from_graph_def() and update comments. [1] onnx/tensorflow-onnx#1946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to current policy:
The default should be set to the latest released version as of 18 months ago.
Update the default opset version to 13 which was released in Nov, 2020.