Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default opset version for tf2onnx. #1946

Merged
merged 3 commits into from
May 25, 2022
Merged

Update the default opset version for tf2onnx. #1946

merged 3 commits into from
May 25, 2022

Conversation

fatcat-z
Copy link
Collaborator

According to current policy:

The default should be set to the latest released version as of 18 months ago.

Update the default opset version to 13 which was released in Nov, 2020.

Signed-off-by: Jay Zhang <jiz@microsoft.com>
@fatcat-z fatcat-z requested a review from hwangdeyu May 24, 2022 06:39
Signed-off-by: Jay Zhang <jiz@microsoft.com>
@fatcat-z
Copy link
Collaborator Author

Resolve the issue #1911.

Copy link
Contributor

@hwangdeyu hwangdeyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the README.md#onnx at the same time?

Signed-off-by: Jay Zhang <jiz@microsoft.com>
@fatcat-z
Copy link
Collaborator Author

Update the README.md#onnx at the same time?

Good catch.

Copy link
Contributor

@hwangdeyu hwangdeyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fatcat-z fatcat-z merged commit 880754e into onnx:main May 25, 2022
@fatcat-z fatcat-z deleted the update_default_opset branch May 25, 2022 03:10
yan12125 pushed a commit to archlinuxcn/repo that referenced this pull request Jun 13, 2022
Fix tests failed after the default opset is upgraded from 9 to 13 [1].

Also switches from python-install to python-installer.

[1] onnx/tensorflow-onnx#1946
yan12125 pushed a commit to EMCLab-Sinica/DynBal that referenced this pull request Jul 7, 2022
* CP decomposition

* Tucker-2 decomposition

* QAT

* convert-har: use opset 9 explicitly

Some codes are not compatible with newer opsets yet, while newer tf2onnx
defaults to opset 13 [1]. Specify the opset to keep compaibility.

Also investigates the issue from the newer API
tf2onnx.convert.from_graph_def() and update comments.

* Conv: fix recovery for group convolution

* Faster group convolution

* decomposition/fc: merge small filters

* Double scales for asymmetric quantization

* Add: strip states before scaling inputs

[1] onnx/tensorflow-onnx#1946
archlinux-github pushed a commit to archlinux/aur that referenced this pull request Jul 30, 2022
Fix tests failed after the default opset is upgraded from 9 to 13 [1].

Also switches from python-install to python-installer.

[1] onnx/tensorflow-onnx#1946
yan12125 pushed a commit to EMCLab-Sinica/DynBal that referenced this pull request Aug 7, 2022
Some codes are not compatible with newer opsets yet, while newer tf2onnx
defaults to opset 13 [1]. Specify the opset to keep compaibility.

Also investigates the issue from the newer API
tf2onnx.convert.from_graph_def() and update comments.

[1] onnx/tensorflow-onnx#1946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants