Explicit padding for const shape ConvTranspose #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calvin McCarter <calvin@lightmatter.co>
Signed-off-by: Calvin McCarter <calvin@lightmatter.co>
Signed-off-by: Calvin McCarter <calvin@lightmatter.co>
Signed-off-by: Calvin McCarter <calvin@lightmatter.co>
|
This pull request introduces 1 alert when merging ab23dac into c7231d5 - view on LGTM.com new alerts:
|
TomWildenhain-Microsoft
approved these changes
May 12, 2021
|
This pull request introduces 1 alert when merging 2b4121f into b603705 - view on LGTM.com new alerts:
|
TomWildenhain-Microsoft
suggested changes
May 12, 2021
Signed-off-by: Calvin McCarter <calvin@lightmatter.co>
…-lightmatter/tensorflow-onnx into conv-transpose-padding
TomWildenhain-Microsoft
approved these changes
May 13, 2021
zerollzeng
pushed a commit
to zerollzeng/tensorflow-onnx
that referenced
this pull request
May 16, 2021
* explicit padding for const shape ConvTranspose Signed-off-by: Calvin McCarter <calvin@lightmatter.co> * pylint fix Signed-off-by: Calvin McCarter <calvin@lightmatter.co> * test_backend graph_validator fix Signed-off-by: Calvin McCarter <calvin@lightmatter.co> * keep output_shape if input_dims unknown Signed-off-by: Calvin McCarter <calvin@lightmatter.co> * cleanup Signed-off-by: Calvin McCarter <calvin@lightmatter.co> * remove unused variable Signed-off-by: Calvin McCarter <calvin@lightmatter.co> Co-authored-by: TomWildenhain-Microsoft <67606533+TomWildenhain-Microsoft@users.noreply.github.com> Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a ConvTranspose node with constant shape using explicitly-defined padding rather than output_shape-based padding (issue #1501).