-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an end2end example with tf.keras #1103
Conversation
This pull request introduces 3 alerts when merging 8050277 into 353e46f - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging 2d97157 into 353e46f - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 3714e1d into 353e46f - view on LGTM.com new alerts:
|
examples/end2end_tfkeras.py
Outdated
print('ort:', timeit.timeit("session.run(None, {'input_1:0': input})", | ||
number=100, globals=globals())) | ||
|
||
######################################## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tflite does not contribute much to a example how to convert tf->onnx.
We should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
examples/end2end_tfhub.py
Outdated
index = input_details[0]['index'] | ||
|
||
|
||
def tflite_predict(input, interpreter=interpreter, index=index): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tflite does not contribute much to a example how to convert tf->onnx.
We should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll remove it from the example. Do I keep an example about tflite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would confuse users if we have tflite in examples since we don't support it.
Best to remove it completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
Signed-off-by: xavier dupré <xavier.dupre@gmail.com>
No description provided.