Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing op InvertPermutation #595

Closed
satyajithj opened this issue Jun 14, 2019 · 7 comments
Closed

Missing op InvertPermutation #595

satyajithj opened this issue Jun 14, 2019 · 7 comments

Comments

@satyajithj
Copy link
Contributor

satyajithj commented Jun 14, 2019

Hi. I would like to add the InvertPermutation op to this project.
How do I get started?

@lucienwang1009 lucienwang1009 added the enhancement New feature or request label Jun 14, 2019
@lucienwang1009
Copy link
Collaborator

@fuzzyBatman It seems too complex to compose this op into onnx subgraph. We may need onnx's support to convert this op.

@satyajithj
Copy link
Contributor Author

Oh. Do you have an idea about the process?
Should this op be added to onnx, or to tf-onnx with some feature support from onnx?

@lucienwang1009
Copy link
Collaborator

I believe it should be added to onnx. @guschmue for comments.

@guschmue
Copy link
Contributor

If we need a new op to onnx the process is sometime like this:
-submit a pr to onnx and get it accepted
-wait for the implementation in onnxruntime (we need that only so we can add unit tests in tf2onnx)
-add support for the new op to tf2onnx

@satyajithj
Copy link
Contributor Author

@lucienwang1009 @guschmue I do not understand how ONNX works. I read the adding a new operator section but I am little confused.

Say I want to add the invert_permutation op to ONNX. I should submit a PR to ONNX which contains the Op schema, definition in docs and some test cases, as done in the EyeLike op example PR, and that is it? The implementation is done elsewhere?

@zhijxu-MS
Copy link
Collaborator

ONNX defines opetation schema.
ONNX backend, for example ONNXRunTime, implements ONNX opetaion.

@satyajithj
Copy link
Contributor Author

@zhijxu-MS Thanks!

@guschmue guschmue added needs onnx change and removed enhancement New feature or request labels Jul 16, 2020
xadupre pushed a commit to xadupre/tensorflow-onnx that referenced this issue Sep 29, 2020
@xadupre xadupre closed this as completed in 1e2f4b2 Oct 6, 2020
xadupre added a commit that referenced this issue Oct 6, 2020
Fixes #595, support operator InvertPermutation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants