Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support of python 2.7 #383

Merged
merged 4 commits into from
Apr 10, 2020
Merged

Remove support of python 2.7 #383

merged 4 commits into from
Apr 10, 2020

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Apr 9, 2020

No description provided.

@xadupre xadupre requested a review from wenbingl April 9, 2020 15:41
@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2020

This pull request fixes 1 alert when merging 366cfa9 into 6546438 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

README.md Outdated
@@ -41,8 +41,7 @@ This package relies on ONNX, NumPy, and ProtoBuf. If you are converting a model
7. libsvm
8. H2O

ONNXMLTools has been tested with Python **2.7**, **3.5**, **3.6**, and **3.7**.
`Note: some wrapped converters may not support python 2.x anymore.`
ONNXMLTools has been tested with Python **3.5**, **3.6**, and **3.7**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more details like "since onnxmltools 1.7, it stops the support python 2.x. "

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2020

This pull request fixes 1 alert when merging 32eb0ea into 6546438 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2020

This pull request fixes 1 alert when merging 19a894d into 78b12fd - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@wenbingl wenbingl merged commit 507db05 into onnx:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants