[mlir2FileCheck tool] handle multiple output arguments #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
Signed-off-by: Tung D. Le <tung@jp.ibm.com>
AlexandreEichenberger
approved these changes
Sep 19, 2024
|
Jenkins Linux amd64 Build #15667 [push] [mlir2FileCheck tool] ha... started at 13:49 |
|
Jenkins Linux ppc64le Build #14697 [push] [mlir2FileCheck tool] ha... started at 15:01 |
|
Jenkins Linux s390x Build #15670 [push] [mlir2FileCheck tool] ha... started at 14:49 |
|
Jenkins Linux amd64 Build #15667 [push] [mlir2FileCheck tool] ha... passed after 1 hr 8 min |
|
Jenkins Linux s390x Build #15670 [push] [mlir2FileCheck tool] ha... passed after 1 hr 28 min |
|
Jenkins Linux ppc64le Build #14697 [push] [mlir2FileCheck tool] ha... passed after 2 hr 2 min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python script
mlir2FileCheckdoes not handle multiple output arguments, for example, it prints out:where only the last output has
:%.+. The correct one would beThis fixes the issue by defining a new regex that captures a repeated group that contains all output arguments, then parses them.