-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GroupNorm to support Opset21 #2928
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
c64ad53
Group norm for opset 21
MegoHam21 db003ba
Merge branch 'onnx:main' into hamptonm/feature/groupnorm
hamptonm1 fe10937
Testing phase
MegoHam21 8979ccb
Merge branch 'onnx:main' into hamptonm/feature/groupnorm
hamptonm1 fed2948
Fix GroupNorm to support Opset21
MegoHam21 b650554
Merge branch 'hamptonm/feature/groupnorm' of https://github.com/hampt…
MegoHam21 35692e8
Merge branch 'main' into hamptonm/feature/groupnorm
hamptonm1 7209660
Fix format
MegoHam21 f2e87a4
Merge branch 'hamptonm/feature/groupnorm' of https://github.com/hampt…
MegoHam21 52721fc
Still fixing format here
MegoHam21 32d0132
Trying this out
MegoHam21 fb4b39c
Logic branches
MegoHam21 c6a0ebb
Fix linter
MegoHam21 b36f32d
Try again
MegoHam21 a1a15e3
Update Dockerfile.llvm-project
hamptonm1 3b0bf5f
Update requirements.txt
hamptonm1 770b1c4
Merge branch 'main' into hamptonm/feature/groupnorm
hamptonm1 3f33e0b
Update requirements.txt
hamptonm1 6b7dc63
Testing it
MegoHam21 fd20266
Merge branch 'hamptonm/feature/groupnorm' of https://github.com/hampt…
MegoHam21 8d50a48
Merge branch 'main' into hamptonm/feature/groupnorm
hamptonm1 76de507
Fix format
MegoHam21 31e542c
Merge branch 'hamptonm/feature/groupnorm' of https://github.com/hampt…
MegoHam21 07b4e51
Testing still
MegoHam21 a3e8359
Still figuring this out
MegoHam21 6b3f4dd
Try it out
MegoHam21 da9c0ab
Format fixed
MegoHam21 41ee2b9
Merge branch 'main' into hamptonm/feature/groupnorm
hamptonm1 b9fa3b0
Grr
MegoHam21 654b488
Fixing format
MegoHam21 30337e5
Keep going
MegoHam21 08ff821
Add verifier and cleanup code
MegoHam21 f7d53f7
Fix failure and add lit test
MegoHam21 2a26b17
Merge branch 'main' into hamptonm/feature/groupnorm
hamptonm1 424d807
Fixing up
MegoHam21 16d4c4e
Format again
MegoHam21 84a10c8
Format verifier
MegoHam21 d0b51e2
Figure out why it is not working
MegoHam21 ca8da95
My fault
MegoHam21 d8b26f9
Update Decompose.cpp
hamptonm1 6d35971
Update Decompose.cpp again
hamptonm1 327e6ef
Update Decompose.cpp part 3
hamptonm1 ba471a1
Still at it
hamptonm1 6c2de2d
Test it!
hamptonm1 76e8422
I think I got it to work
MegoHam21 de19219
Hmmm
MegoHam21 e459d52
Address comments
MegoHam21 0f1b161
Fix format
MegoHam21 41eb8dd
Merge branch 'main' into hamptonm/feature/groupnorm
hamptonm1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
lit~=15.0 | ||
# numpy 1.24 deprecates np.object, np.bool, np.float, np.complex, np.str, | ||
# and np.int which are used heavily in onnx-mlir. | ||
numpy~=1.22.2, <=1.23.5 | ||
numpy==2.0.1 | ||
onnx==1.16.2 | ||
protobuf==4.21.12 | ||
pytest~=7.2 | ||
pytest-xdist~=3.0 | ||
pytest==8.3.2 | ||
pytest-xdist==3.6.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexandreEichenberger Is this what you were thinking of? I added a print because if I add
emitWarning
it seems like all opset 18 tests fail and I figure we can still enable support for the meantime. I am fine with removing support in the near future but was not sure if any model still uses GroupNorm Opset 18.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, in general, we can also test other properties, but since this op is not going to be used, its fine.