Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling errors in comments and documentation #1669

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

e10e3
Copy link
Contributor

@e10e3 e10e3 commented Jan 31, 2025

This PR fixes some typos found in the code comments, docstrings, and notebooks.

Most errors were found with codespell.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@gbolmier gbolmier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most errors were found with codespell.

Could be helpful as a CI job. 2 small changes to make otherwise LGTM ✅

@@ -38,7 +38,7 @@ class SDFT(base.Base):

References
----------
[^1]: [Jacobsen, E. asample_average.pynd Lyons, R., 2003. The sliding DFT. IEEE Signal Processing Magazine, 20(2), pp.74-80.](https://www.comm.utoronto.ca/~dimitris/ece431/slidingdft.pdf)
[^1]: [Jacobsen, E. and Lyons, R., 2003. The sliding DFT. IEEE Signal Processing Magazine, 20(2), pp.74-80.](https://www.comm.utoronto.ca/~dimitris/ece431/slidingdft.pdf)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[^1]: [Jacobsen, E. and Lyons, R., 2003. The sliding DFT. IEEE Signal Processing Magazine, 20(2), pp.74-80.](https://www.comm.utoronto.ca/~dimitris/ece431/slidingdft.pdf)
[^1]: [E. Jacobsen and R. Lyons, 2003. The sliding DFT. IEEE Signal Processing Magazine, 20(2), pp.74-80.](https://www.comm.utoronto.ca/~dimitris/ece431/slidingdft.pdf)

river/neighbors/knn_regressor.py Outdated Show resolved Hide resolved
Co-authored-by: Geoffrey Bolmier <geoffrey.bolmier@gmail.com>
@MaxHalford MaxHalford merged commit 18f31d6 into online-ml:main Feb 3, 2025
5 checks passed
@e10e3 e10e3 deleted the spelling branch February 7, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants