add stop/delete experiment endpoint #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- track list of celery task ids and cancel running tasks to free up the space
MaxHalford
approved these changes
Feb 16, 2023
api/api/experiments.py
Outdated
| @@ -149,9 +150,11 @@ class Experiment(sqlm.SQLModel, table=True): # type: ignore[call-arg] | |||
| runner: runners.Runner = sqlm.Relationship(back_populates="experiments") | |||
| sink_id: int = sqlm.Field(foreign_key="sink.id") | |||
| sink: sinks.Sink = sqlm.Relationship(back_populates="experiments") | |||
| task_ids: str | None = sqlm.Field(default=None) | |||
There was a problem hiding this comment.
I think a cleaner way than using str is to store the IDs in a list; see here
There was a problem hiding this comment.
thanks, i was looking for that.
I tried task_ids: List[str] and variations of that but was not working.
| if not exp: | ||
| raise HTTPException(status_code=404, detail="Experiment not found") | ||
| for task_id in exp.task_ids.split(","): | ||
| RUNNER.control.revoke(task_id, terminate=True) |
|
|
||
|
|
||
| @router.delete("/{experiment_id}") | ||
| def delete_experiment(experiment_id: int): |
There was a problem hiding this comment.
Do the tasks need to be stopped if the experiment is deleted?
when deleting experiment also stop the corresponding training and inference tasks from running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature pr: add additional way of running training and inference jobs that are infinite in its nature