Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ai review to functional #2973

Draft
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

GreenAsJade
Copy link
Contributor

Fixes need to wrap AIReview for context, and other React.Component limitations

Proposed Changes

  • Followed the steps to convert to functional

BUT

I tried to set up tests for this and it proved too hard to mock. I had intended to at least make sure the same tests pass on before and after.

It has a lot of conditional stuff in it, so it's hard to be sure some use-case is not broken.

@GreenAsJade GreenAsJade marked this pull request as draft February 25, 2025 06:45
@GreenAsJade GreenAsJade marked this pull request as ready for review February 25, 2025 06:45
@GreenAsJade GreenAsJade requested a review from anoek February 25, 2025 06:45
@anoek
Copy link
Member

anoek commented Feb 25, 2025

Nice, this was one of the big ones that was still a class :)

First thing I notice is when loading an existing review, instead of the graph popping up instantly it seems to be waiting for some UI update. If I reload and hit an arrow key to go back a move, it pops up instantly then, so I think it just needs a refresh at some appropriate time, I'd assume after loading but unsure.

The other thing I notice is when exploring variations I'm not seeing any updates on the board to show what the AI is thinking, the graph also seems delayed. Going back a move and then forward again does show the updates, so I think it's a similar issue as above, but maybe not the same thing.

@anoek
Copy link
Member

anoek commented Feb 25, 2025

It's up on beta, might replicate better on there for you if you were seeing everything working as expected on your local dev system.

@GreenAsJade GreenAsJade marked this pull request as draft February 25, 2025 23:20
@GreenAsJade
Copy link
Contributor Author

Darn - I think I'll need to solve "why doesn't AI work in my Dev environment" first.

And, darn, the fragile ViewReport page has become unworkable, so I think I need to deal with that first.

Hence parking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants