keep processing html on image download error #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first thanks a lot for this library!
We've been using it for a while, and today got a bug that, after investigation, turned out to be due to an image that is not hosted anymore and that takes a while to resolve in a timeout error.
The way the lib is currently handling Image downloads, if any download fail then the error cascades all the way and an empty docx is generated.
In our case we found that it is desirable to fail gracefully and still generate the docx without the missing image, and just log the error for further analysis.
It would be great if we could get this merged, or if you have other suggestions please let me know!
Thanks!