This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fix updating detailed completion for overloaded methods #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For languages that allow method overloads, where the same method name can be defined with different arguments (e.g. C++), the `label` of a completion may be duplicated in the completions list, but the `detail` should be different. * Hence use the `detail` field, if available, to disambiguate between completion items when updating them with the result of a `completionItem/resolve`.
|
An example from cquery (C++) completions Before the fix - both completion items appear to be duplicates: With the fix the second "duplicate" item shows it's different signature: |
Codecov Report
@@ Coverage Diff @@
## master #2633 +/- ##
==========================================
+ Coverage 45.33% 45.38% +0.04%
==========================================
Files 361 361
Lines 14572 14576 +4
Branches 1913 1915 +2
==========================================
+ Hits 6606 6615 +9
+ Misses 7741 7737 -4
+ Partials 225 224 -1
Continue to review full report at Codecov.
|
akinsho
approved these changes
Oct 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be defined with different arguments (e.g. C++), the
labelof acompletion may be duplicated in the completions list, but the
detailshould be different.
detailfield, if available, to disambiguate betweencompletion items when updating them with the result of a
completionItem/resolve.