Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Feature/ Make tab bar border-bottom theme-able #2585

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

akinsho
Copy link
Member

@akinsho akinsho commented Sep 27, 2018

This PR is one of some upcoming which allows specific sections of oni's ui that currently default to other colors in the theme specifically themable, in this case the border bottom of the tab bar default to tabs.background meaning it can't be specifically styled or hidden which is less flexible. This PR adds a specific config for this setting but maintains the default of tabs.background if no specific key is specified so it is backwards-compatible

@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #2585 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2585   +/-   ##
=======================================
  Coverage   45.26%   45.26%           
=======================================
  Files         361      361           
  Lines       14564    14564           
  Branches     1908     1908           
=======================================
  Hits         6593     6593           
  Misses       7747     7747           
  Partials      224      224
Impacted Files Coverage Δ
browser/src/UI/components/Tabs.tsx 77.86% <ø> (ø) ⬆️
browser/src/Services/Themes/ThemeManager.ts 69.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d448d49...4e017bb. Read the comment docs.

Copy link
Member

@CrossR CrossR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akinsho akinsho merged commit 15a2ca9 into onivim:master Oct 4, 2018
@akinsho akinsho deleted the feature/make-tab-bar-border-themable branch October 4, 2018 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants