Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Fixed problem when some visual artifacts may appear after resize #2578

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

lenenel
Copy link
Contributor

@lenenel lenenel commented Sep 22, 2018

I have menu hidden by default and observed visual artifacts after pressing Alt. Menu appears after I press Alt and editor area is resized, but not the whole area is redrawn, so I see 2 neovim's status bars. I also can reproduce similar behaviour by resizing Oni window.
See video with this problem

After investigation I've found that method CanvasRenderer.redrawAll is called before neovim is really resized so it draws state of neovim before resize. So I've changed code so it called only when Promise returned by NeovimInstance.resize method is resolved. Which is actually Promise returned by Session.request method, so should be resolved when neovim finished resizing itself.

@codecov
Copy link

codecov bot commented Sep 22, 2018

Codecov Report

Merging #2578 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2578   +/-   ##
=======================================
  Coverage   45.44%   45.44%           
=======================================
  Files         353      353           
  Lines       14445    14445           
  Branches     1885     1885           
=======================================
  Hits         6564     6564           
  Misses       7657     7657           
  Partials      224      224
Impacted Files Coverage Δ
browser/src/Editor/NeovimEditor/NeovimRenderer.tsx 8.69% <0%> (ø) ⬆️
browser/src/neovim/NeovimInstance.ts 5.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966fd2c...f831c31. Read the comment docs.

@CrossR
Copy link
Member

CrossR commented Sep 27, 2018

Sorry for the delay! If nobody else has got this, I'll take a look at the Weekend.

Copy link
Member

@CrossR CrossR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests have all passed and I didn't see any issues when I used this for the past few days!

Cheers for the contribution @lenenel!

@CrossR CrossR merged commit 5c9a9cd into onivim:master Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants