This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fixed problem when some visual artifacts may appear after resize #2578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have menu hidden by default and observed visual artifacts after pressing Alt. Menu appears after I press Alt and editor area is resized, but not the whole area is redrawn, so I see 2 neovim's status bars. I also can reproduce similar behaviour by resizing Oni window.
See video with this problem
After investigation I've found that method
CanvasRenderer.redrawAll
is called before neovim is really resized so it draws state of neovim before resize. So I've changed code so it called only when Promise returned byNeovimInstance.resize
method is resolved. Which is actually Promise returned bySession.request
method, so should be resolved when neovim finished resizing itself.