Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Extra Highlight/Cell info #2566

Merged
merged 2 commits into from
Sep 24, 2018
Merged

Conversation

CrossR
Copy link
Member

@CrossR CrossR commented Sep 10, 2018

This just hooks up the last bits of the highlight info from the highlight_set event, so that we can use it in the future for the underline colour and the undercurls.

@codecov
Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #2566 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2566      +/-   ##
==========================================
- Coverage   45.44%   45.41%   -0.03%     
==========================================
  Files         353      353              
  Lines       14445    14453       +8     
  Branches     1885     1889       +4     
==========================================
  Hits         6564     6564              
- Misses       7657     7665       +8     
  Partials      224      224
Impacted Files Coverage Δ
browser/src/neovim/NeovimInstance.ts 5.47% <ø> (ø) ⬆️
browser/src/neovim/actions.ts 46.77% <0%> (-1.56%) ⬇️
browser/src/neovim/Screen.ts 4.03% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6595e6...24d0a2c. Read the comment docs.

Copy link
Collaborator

@manu-unter manu-unter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the plumbing here, I would have had to look for the right places to do this for quite some time :)

@manu-unter manu-unter merged commit 6bbb541 into onivim:master Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants