This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Fix CURRENT_MONTH Snippet variable. #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added some of the other variables commented out, to be added later.
Codecov Report
@@ Coverage Diff @@
## master #2530 +/- ##
=======================================
Coverage 44.51% 44.51%
=======================================
Files 351 351
Lines 14302 14302
Branches 1865 1865
=======================================
Hits 6367 6367
Misses 7709 7709
Partials 226 226
Continue to review full report at Codecov.
|
|
Sweet! Thanks for adding these @CrossR 💯 Looks great! |
bryphe
approved these changes
Sep 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current month snippet variable, since its zero indexed. Having the month be one less than expected is a bit odd, so I brought it inline with VSCode (which the snippet provider is from).
I also added the other date based variables, and some placeholders for the others. I'm not sure if we will need them, and they are a bit more involved, so I left them for now. I also swapped the order around so it matches VSCode code base, which makes comparing a little easier.