Fix for #2414 - truncated copy/paste

[psxpaul]

This is a fix for some of the issues raised in #2414. One thing to note - there was some question as to whether win32yank works for everyone. I did find a possible workaround for that, if it's still an issue:

const textToPaste = clipboard.readText()
const sanitizedTextLines = replaceAll(textToPaste, { "'": "''" })
await neovimInstance.command("let @+='" + sanitizedTextLines + "'")

I don't have a windows box to test this on, so perhaps we can add this code to NeovimEditorCommands. pasteContents later if needed.

[badosu]

<c-x> in visual mode decrements an integer value under the cursor

[psxpaul]

Thanks for the heads up, I'll remove this part

[codecov]

Codecov Report

Merging #2515 into master will decrease coverage by 0.02%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##           master    #2515      +/-   ##
==========================================
- Coverage    43.6%   43.57%   -0.03%     
==========================================
  Files         351      351              
  Lines       14176    14186      +10     
  Branches     1845     1846       +1     
==========================================
+ Hits         6181     6182       +1     
- Misses       7758     7767       +9     
  Partials      237      237

Impacted Files	Coverage Δ
...er/src/Editor/NeovimEditor/NeovimEditorCommands.ts	11.94% <6.66%> (-0.35%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f65e6...eb48006. Read the comment docs.

[CrossR]

I can give this a test on a clean Windows VM to check if a base config works with this new method. That way, if people have an issue with win32yank, its most likely their config.

[akinsho]

@psxpaul seems the large paste test is repeatedly failing on windows 😭 we might need the solution in the snippet you pasted for windows

[CrossR]

I've not had a chance to test this yet, but I've set a reminder to do it tonight, so should be able to test it then. I'll also give it a test on my normal dev box, see if its all Windows or just the CI / base config versions of Oni.

[CrossR]

This is pretty odd....I ran the CI tests locally, it passed fine twice. I started Oni, pasted and copied a bunch, all good.

Then I tried it one last time, and now there is no clipboard provider registered, :checkhealth says its not hooked up...

Even weirder, I reloaded Oni (Ctrl-Shift-P -> Reload) and :checkhealth was fine. Reloaded again, was bad. One last reload....everything fine again.

[psxpaul]

Thanks for trying it out @CrossR. I got a Windows VM setup and managed to get the win32yank workaround working. I wasn't sure if this workaround should only be applied for windows machines, but the approach seems to work fine on my Mac and Linux machines.

[akinsho]

@psxpaul thanks for all the work on this 👍, glad its working crossplatform now

[josemarluedke]

This PR might hame created a issue when pasting on command. Say I start a search with / and paste using cmd + v. The content will actually be pasted under the buffer that was focused instead of putting that content on the search.