Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

added dracula theme #2408

Merged
merged 2 commits into from
Jul 12, 2018
Merged

added dracula theme #2408

merged 2 commits into from
Jul 12, 2018

Conversation

xeaone
Copy link
Contributor

@xeaone xeaone commented Jul 6, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jul 6, 2018

Codecov Report

Merging #2408 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2408      +/-   ##
==========================================
+ Coverage   38.19%   38.23%   +0.03%     
==========================================
  Files         300      300              
  Lines       12522    12530       +8     
  Branches     1649     1650       +1     
==========================================
+ Hits         4783     4791       +8     
  Misses       7484     7484              
  Partials      255      255
Impacted Files Coverage Δ
browser/src/Services/Snippets/SnippetSession.ts 81.33% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf93fe0...94f33e1. Read the comment docs.

@CrossR
Copy link
Member

CrossR commented Jul 7, 2018

Since its nice to have an image for themes:

image

Looks good to me though! Only point I have is maybe having the tabs stick out from the background a bit more? As it is, the tabs are hard to distinguish from the background colour. I set "background": "#191A21", to get it a little darker.

Also, is there a reason for using Dracula 1.2.7 vs the latest version (which I think is 1.5.0) : https://github.com/dracula/vim/blob/master/colors/dracula.vim. Thats where I got the darker background colour from as well.

@xeaone
Copy link
Contributor Author

xeaone commented Jul 8, 2018

Sounds good. I updated to the darker color and fixed the old vim color version.

I must have downloaded an old commit of the repo.

@bryphe
Copy link
Member

bryphe commented Jul 12, 2018

Just tested out the update - looks great @AlexanderElias ! 💯

image

I like the mode highlight colors a lot (and I like the look of the background with the darker color).

Thanks for the contribution @AlexanderElias - bringing it in now!

@bryphe bryphe merged commit 0572848 into onivim:master Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants