This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Feature/allow for generalised indent handling #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect indent amount
CrossR
approved these changes
Jun 30, 2018
Codecov Report
@@ Coverage Diff @@
## master #2375 +/- ##
=======================================
Coverage 38.11% 38.11%
=======================================
Files 300 300
Lines 12519 12519
Branches 1645 1645
=======================================
Hits 4771 4771
Misses 7494 7494
Partials 254 254Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue raised in discord by @CrossR where the plugins indentation was off if there was an uneven number of indents on a line by rather than taking the naked value from
detect-indentwhich basically just reports the number of spaces at the beginning of the line, and converts that to the highest multiple of indents.This actually allowed me to remove the comment specific code in the layer.