Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

added elixir syntaxes #2325

Merged
merged 1 commit into from Jun 28, 2018
Merged

added elixir syntaxes #2325

merged 1 commit into from Jun 28, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2018

This adds the syntaxes for the Elixir programming language. These were lifted from https://github.com/fr1zle/vscode-elixir. This will possibly fix #735 and allow the elixir-ls langserver to work, but I am not sure how to test this. I also don't know how to test that this works, i tried to run yarn run start but the electron application was just a blank screen. I followed the instructions on the development page in the wiki but maybe got offtrack somewhere.

@codecov
Copy link

codecov bot commented Jun 15, 2018

Codecov Report

Merging #2325 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2325   +/-   ##
=======================================
  Coverage   37.34%   37.34%           
=======================================
  Files         298      298           
  Lines       12352    12352           
  Branches     1632     1632           
=======================================
  Hits         4613     4613           
  Misses       7490     7490           
  Partials      249      249
Impacted Files Coverage Δ
...src/Services/Configuration/DefaultConfiguration.ts 87.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de149d9...7473853. Read the comment docs.

Copy link
Member

@CrossR CrossR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution @colbydehart!

Should make the Oni-Elixir syntax highlights better out of the box.

Is this okay to merge @Akin909? (Only asking since I saw you'd +1 the original post)

@akinsho
Copy link
Member

akinsho commented Jun 20, 2018

@CrossR yeah would have merged it but was thinking of running it locally first as @colbydehart wasn't able to test it himself from the code changes it looks fine though

@akinsho akinsho merged commit 1462bf7 into onivim:master Jun 28, 2018
@MikaAK
Copy link
Contributor

MikaAK commented Jun 28, 2018

Excited to see this in!

@arhyth
Copy link

arhyth commented Oct 21, 2018

hi! sorry putting this here but i don't want to create an issue for a simple question and i couldn't find any link to a forum/chat or anything related in the FAQ.

anyway, my noob question is, is there any additional configuration needed for Oni on top of out-of-the-box config to recognize elixir syntax? it's still showing euphoria3 in the language 'label' at the bottom left of the window. on my neovim, however, elixir syntax is properly recognized and highlighted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrating with elixir alchemist
4 participants