Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

#186 - Part 1 - Initial plugin installer implementation #1883

Merged
merged 5 commits into from
Mar 22, 2018

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Mar 22, 2018

This is an initial implementation of a bundled plugin manager (well, installer / uninstaller).

It turns out yarn can handle both npm and direct-from-git installs, and it has a standalone version. This is similiar to what hyper does to facilitate plugin installs.

This adds an interface like Oni.plugins.installer.install("tpope/vim-surround"), which will download and install that to the user's plugin folder.

A few things coming in next:

  • Notification support - show a notification while the install is in progress.
  • Ability to add plugins via a config option (plugins: ["tpope/vim-surround", "oni-plugin-tslint"])
  • Ability to disable plugins in the sidebar pane
  • Ability to open plugins folder from the sidebar pane
  • Additional metrics / info available in sidebar pane (ie, activation time, errors)

@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #1883 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1883      +/-   ##
==========================================
- Coverage   30.18%   30.17%   -0.02%     
==========================================
  Files         238      238              
  Lines        9021     9024       +3     
  Branches     1351     1351              
==========================================
  Hits         2723     2723              
- Misses       5605     5608       +3     
  Partials      693      693
Impacted Files Coverage Δ
...rowser/src/Services/Explorer/ExplorerFileSystem.ts 64.28% <0%> (-17.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e397df...6682596. Read the comment docs.

@bryphe bryphe merged commit f4e6270 into master Mar 22, 2018
@bryphe bryphe deleted the bryphe/186.1/plugin-management branch March 22, 2018 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant