This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
addLayer
API on theBuffer
object. This is the realization of part of the strategy called out in #362 - having custom UI implement on top of a buffer.This opens the door for several features:
It can also be used to handle some of our existing functionality. I'd like to refactor out some pieces of our
NeovimEditor
and move them into layers. Some layers that would basically be plug-and-play are the ones that are already in the<NeovimActiveWindow>
in our<NeovimSurface>
component:In addition, I could image even moving some pieces like the cursor or canvas rendering out to layers, too (longer-term). This prevents us from doing duplicate rendering work, as today, the canvas is still being rendered underneath the layer.