Oni wont't open when passed a number as first parameter

[Gahen]

Oni Version: 0.3.6
Operating System: macOS Sierra

Issue: Running oni from the command line with a number as first parameter won't open the editor

Expected behavior: I should see the filesystem tool and the editor area

Actual behavior: I only see the system menu bar and the window UX

Steps to reproduce: open a terminal; run oni 123

Maybe this is only happening to me? I would be available to follow any debug step needed.

This is what I get:

[oni-bot]

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

[CrossR]

Hey, sorry for the slow reply!

This looks to be that the path checking logic we have fails in some fashion for just numbers:

I think this is type of the input being swapped to an int when just numbers are passed. Any other string seems to work (123.txt etc). The fix here should just be to force it always to a string, as well as not crashing if there is an error there.

The lines in question are these:

oni/browser/src/App.ts

Lines 110 to 112 in e3f65e6

	const normalizedFiles = parsedArgs._.map(
	arg => (path.isAbsolute(arg) ? arg : path.join(currentWorkingDirectory, arg)),
	)

We can either swap the type just in there, or just update minimist to always treat everything as a string (except stuff like the debug flag etc).

I'll tag this as a good first issue since it seems easy enough, though we should try and get this sorted before the next release.

[Gahen]

Awesome! Thanks for giving it a look.